[Ns-bugs] [Bug 505] WifiNetDevice::Rx trace is also called for overheard frames

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=505


Craig Dowell <craigdo at ee.washington.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |craigdo at ee.washington.edu




--- Comment #6 from Craig Dowell <craigdo at ee.washington.edu>  2009-03-18 14:15:28 EDT ---
> MacRx: A packet has been received by this device, has been passed 
> up from the physical layer and is being forwarded up the local 
> protocol stack.

> Compare with the original comment:
>> I would expect the Rx trace source to be invoked only when the 
>> L2 receives a frame that is to be forwarded to upper layers, 
>> i.e. it is either broadcast, multicast or unicast and directed
>>  to the current host.

MacRx does the same thing that the source formerly known as m_rxLogger.

The idea was that MacRx got hit on all the packets.  Sniffer had the 
filtering done that Francesco wanted.

Writing a Sniffer trace in the current highly modular wifi became way 
more painful and nasty than anyone wanted, so the Sniffer was removed
(not commented out). This leaves wifi twisting in the wind with no 
Sniffer trace and no trace for PACKET_HOST packets.

Right now the PACKET_HOST, PACKET_OTHERHOST decisions are made in 
wifi-net-device and the MacRx trace sources are hit in wifi-mac.

In order to provide what Francesco wants, perheps we want another trace
source, MacLocalRx or MacHostRx (to match up with PACKET_HOST) to 
differentiate between these cases.  I can add this to WifiMac quite 
easily.  It seems like a worthwhile addition (to all devices).  Since
this isn't a pcap-ready trace, I won't bother to add the offensive 
Ethernet header to the traced packet.

I should also remove the vestigal m_rxLogger and m_txLogger that are 
still there, BTW.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.