[Ns-bugs] [Bug 505] WifiNetDevice::Rx trace is also called for overheard frames

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=505





--- Comment #4 from Mathieu Lacage <mathieu.lacage at sophia.inria.fr>  2009-03-18 10:53:43 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > I believe that craig's latext patch did not improve the situation for you,
> > francesco, right ? Can you confirm that the latest code does not do what you
> > were expected ?
> > 
> 
> Mathieu, if I understand correctly, this was removed from the tracing patch
> because you did not want to see the packet copy there.  Presently, there is a
> non-promiscuous sniff trace source that is commented out-- are we going to
> leave it that way and ask users interested in that trace source to uncomment
> it?
>

1) If there is a piece of commented code, I am not aware of it and I missed it
during my code review. 

2) What francesco wants is what I think craig called a 'sniff' trace but
francesco does not care about the extra ethernet header craig wanted to add
there so, francesco would be happy with an extra trace which does not try to
add an ethernet header and that should trivial to add to the current codebase.
I guess that we should not name it 'sniff' to avoid confusion with craig's own
traces but, I really don't care personally: I don't really see the point of
this whole 'tracing must be uniform' thing.

Basically, to summarize, from the POV of francesco, the current code is far
from an improvement since it removes the rx trace source from
wifi-net-device.cc and thus makes it harder for him to get what he wants.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.