[Ns-bugs] [Bug 556] DcfManager does not handle AckTimeout properly when there are multiple queues

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=556





--- Comment #12 from Mathieu Lacage <mathieu.lacage at sophia.inria.fr>  2009-06-08 04:11:32 EDT ---
(In reply to comment #11)
> Created an attachment (id=455)
 --> (http://www.nsnam.org/bugzilla/attachment.cgi?id=455) [details]
> Full patch: bugfix + test-cases
> 
> Test cases are described in picture in comments. All previous tests are filled
> with ack-timeout starting and cancelling
> 

Thank you very much: this looks totally awesome. A couple more comments (the
idea of touching that piece of code makes me crazy which is why I am so super
careful):

1) ./waf --regression does not pass: I am looking into it but you can beat me
to it.

2) I know that you are going to hate me but if I remove your calls to
GetTimeStep, "./waf check" still passes ("./waf --regression hangs"). If you
really want me to take these 2 lines in the patch, you would have to put
together a testcase which fails without these 2 lines so that we understand
really why they are here.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.