[Ns-bugs] [Bug 614] [PATCH] Feature to allow to injecting routes to GlobalRouting

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=614





--- Comment #12 from Antti Mäkelä <zarhan at cc.hut.fi>  2009-07-13 03:43:36 EDT ---
(In reply to comment #11)
> I support this addition, once it is finished off and tested more.  Here are
> some open issues:
> - ./waf --valgrind --run global-injection-slash32 displays memory leaks

  Valgrind was easy enough to fix - I just had forgotten to clean up the
InjectedRoutes and ASExternalRoutes at the ipv4-global-routing's DoDispose().
(I thought the Ptr<> smart pointers included garbage collection as well, as
soon as all references are gone the object would be killed as well, but guess
not)

  Will check coding style too. 

  The GetGlobalRouting one - it's something that is present in same format in
static helper (that's basically copypasted from there). 
  If included in global routing helper, should it be public or private function
(will there be cases for end-users to access it directly, or should it just be
something that a Helper-Inject uses internally?)


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.