[Ns-bugs] [Bug 634] [PATCH] Feature to grab Network Length out of Ipv4Mask

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=634





--- Comment #3 from Antti Mäkelä <zarhan at cc.hut.fi>  2009-07-10 04:21:30 EDT ---
(In reply to comment #2)
> What about improving the implementation to detect a leading slash, and also
> allow these strings?
> 
> Ipv4Mask ("/32")
> Ipv4Mask ("/24")
> etc.

  Sounds like a good idea. 

> > (Ipv6Prefix::Ipv6Prefix(uint8_t) DOES exist). 
> > 
> > Also Ipv6Prefix class didn't seem to have a convention for function name to
> > simply get the length, so I used this one.
> I didn't quite understand the above comment-- you are saying that you invented
> "GetMaskLength()" because there was no corresponding "GetPrefixLength()"
> function in IPv6?  Should you also add a similar length function to
> Ipv6Prefix?

  Since Ipv4 stuff seems to talk about Masks (class name: Ipv4Mask) and Ipv6
talks about prefixes (Ipv6Prefix) I went with "Mask" here just to keep with
what seemed to be convention on Ipv4 side. So it's just whether this should be
called GetPrefixLength() or GetMaskLength().

  And yeah, I would eventually need this on Ipv6 side as well, should be easy
enough to implement as well. 


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.