[Ns-bugs] [Bug 532] ./waf --valgrind --regression passes despite memory leak

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=532


Mathieu Lacage <mathieu.lacage at sophia.inria.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.lacage at sophia.inria.
                   |                            |fr




--- Comment #11 from Mathieu Lacage <mathieu.lacage at sophia.inria.fr>  2009-04-16 10:12:20 EDT ---
(In reply to comment #10)
> OK for me.  I have some nitpicks, but nothing important.
> 
> If you want to improve your patch, you can:
> 
>  1. Not use os.popen, use subprocess.Popen instead;

ok

>  2. Not create a wrapper script, instead regexp-filter in the parent process
> (via redirect stderr to a pipe and process lines from the pipe instead).

I tried to do this but I could not find how to do this in the wscript which
builds a command from wutils.py get_command_template. I fear that doing this
within the wscript would require extensive changes to the wscript itself, right
?


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.