[Ns-bugs] [Bug 532] ./waf --valgrind --regression passes despite memory leak

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=532





--- Comment #10 from Gustavo J. A. M. Carneiro <gjcarneiro at gmail.com>  2009-04-16 09:59:11 EDT ---
OK for me.  I have some nitpicks, but nothing important.

If you want to improve your patch, you can:

 1. Not use os.popen, use subprocess.Popen instead;
 2. Not create a wrapper script, instead regexp-filter in the parent process
(via redirect stderr to a pipe and process lines from the pipe instead).

But for the time being, no objections.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.