[Ns-bugs] [Bug 314] New: NSC support wscript changes appear buggy

[bugzilla-daemon@nsnam-www.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=314

           Summary: NSC support wscript changes appear buggy
           Product: ns-3
           Version: ns-3.2
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: build system
        AssignedTo: gjcarneiro at gmail.com
        ReportedBy: gjcarneiro at gmail.com
                CC: ns-bugs at isi.edu


in src/internet-stack/wscript

    if arch == 'x86_64' or arch == 'i686' or arch == 'i586' or arch == 'i486'
or arch == 'i386':
        conf.env['NSC_ENABLED'] = 'yes'
        conf.define('NETWORK_SIMULATION_CRADLE', 1)
        conf.write_config_header('ns3/core-config.h')
        e = conf.create_library_configurator()
        e.mandatory = True
        e.name = 'dl'
        e.define = 'HAVE_DL'
        e.uselib = 'DL'
        e.run()
        ok = True

First, what is the "conf.write_config_header('ns3/core-config.h')" doing there?
It overwrites an existing configuration header.  Sounds like a copy paste
error.  I'll rename this header file to internet-stack-config.h, if no
objections.

Next,
        e.run()
        ok = True

Shouldn't this be:
        ok = e.run()
?

Finally I think it is more modular to move opt.add_option('--nsc', ...) from
the toplevel wscript file into src/internet-stack/wscript, for better
organization.

I'll fix these things if no objections.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.