[Ns-bugs] [Bug 284] cannot use config paths to get a handle on an object

[bugzilla-daemon@nsnam-www.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=284





------- Comment #11 from gjcarneiro at gmail.com  2008-10-21 05:57 -------
(In reply to comment #10)
> I think that you are confused. This is really a regexp match and we return the
> result of the match.

Righ, I was confused! That's what you get for reading bug reports in a hurry...
:P  So never mind my previous comments.

So, looking at this more closely, I like it very much.  Only two comments:

  1. >   void Set (std::string attribute, const AttributeValue &v);
    I would prefer SetAttribute here, or maybe SetAttributeForeach.  It took me
a few seconds to figure out what this 'Set' was supposed to do, until I figured
out it must be "set an attribute on the object(s) pointed to by the trace path.
 Also it makes it more consistent with ObjectBase::SetAttribute;

  2. This is a great opportunity to factor in a fix for bug #127 ;-) i.e.
provide a way to obtain the callback signature for a trace path.  So, if you
could add a method like const std::type_info & GetCallbackType (), or
GetCallbackType (int i), it should be enough to get tracing working for Python
bindings, with some additional effort on my part.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.