[Ns-bugs] [Bug 404] New: ErrorModel attribute name is not consistent across devices

code@nsnam.ece.gatech.edu code at nsnam.ece.gatech.edu
Fri Nov 7 07:39:22 PST 2008


http://www.nsnam.org/bugzilla/show_bug.cgi?id=404

           Summary: ErrorModel attribute name is not consistent across
                    devices
           Product: ns-3
           Version: ns-3-dev
          Platform: All
        OS/Version: All
            Status: ASSIGNED
          Severity: normal
          Priority: P3
         Component: devices
        AssignedTo: craigdo at ee.washington.edu
        ReportedBy: tomh at tomh.org
                CC: ns-bugs at isi.edu
   Estimated Hours: 0.0


IMO, the name of this attribute should be aligned across devices, even though
it is an API change.

In PointToPoint:
                   .AddAttribute ("ReceiveErrorModel",
                   "The receiver error model used to simulate packet loss",
                   PointerValue (),
                   MakePointerAccessor
(&PointToPointNetDevice::m_receiveErrorModel),
                   MakePointerChecker<ErrorModel> ())

In CSMA:
                   .AddAttribute ("RxErrorModel",
                   "The receiver error model used to simulate packet loss",
                   PointerValue (),
                   MakePointerAccessor (&CsmaNetDevice::m_receiveErrorModel),
                   MakePointerChecker<ErrorModel> ())

(Note:  there presently is no ReceiveErrorModel in Bridge, SimpleNetDevice, or
Wifi.  I would also propose to add this attribute to SimpleNetDevice, at the
very least, once the naming alignment is settled.  Is there a reason why not to
include in all current NetDevices?)


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the Ns-bugs mailing list