[Ns-bugs] [Bug 139] Packet::RemoveTag is misleading

[bugzilla-daemon@nsnam-www.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=139





------- Comment #2 from mathieu.lacage at sophia.inria.fr  2008-02-14 11:49 -------
(In reply to comment #0)
> Yes, I am frustrated because Packet::RemoveTag has deceived me and made me
> waste a lot of time.
> 
> I had some code that used to do pkt->PeekTag (tag).  It turns out I discovered
> a case where a packet was being re-routed and the same tag was being re-added. 
> So I logically decided to switch to pkt->RemoveTag (tag).
> 
> After an hour wasted (it was not obvious) in debugging it turned out this was a
> bad move. Packet::RemoveTag (tag) does not actually copy the tag!

sounds like a bug since the documentation clearly says it should.

> 
> 1. Why does Packet::RemoveHeader (header) remove and return the header, but
> Packet::RemoveTag (tag) only removes the tag; this is very inconsistent...

Patch to align RemoveTag with RemoveHeader would be welcome. Another option
would be, of course, to update the RemoveTag documentation to align it with its
current implementation. Either way would be fine with me.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.