[Ns-bugs] [Bug 136] Sockets bound to specific interfaces receive broadcasts arriving on other interfaces

[bugzilla-daemon@nsnam-www.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=136


gjcarneiro at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




------- Comment #5 from gjcarneiro at gmail.com  2008-02-13 12:31 -------
(In reply to comment #4)
> I support the patch; just had a couple of nits:
> 
> +      ipv4_api->FindInterfaceForAddr (ipv4); // check if address matches a
> local interface
> 
> I would change the above comment to // asserts if requested address is not
> found

Agree; will change it.

> 
> I was looking at this function for a while and wondering "why is the return
> value ignored?"

I'll change to NS_ASSERT (ipv4_api->FindInterfaceForAddr (ipv4) != 0), to make
the code clearer.  (the outer assert will never be invoked, but it doesn't
hurt).

> 
> Also,
> +  Ipv4Address m_localInterface; // local interface (optional)
> 
> In what sense is this optional?  I see it as a mandatory parameter everywhere. 
> Does "(optional)" mean optional in the sense that the user calling Bind is
> optional?

+  Ipv4Address m_localInterface; // local interface (optional)

It is optional in the sense that localInterface can be Ipv4Address::GetAny (),
which means the end point is not associated with any particular interface.  I
will clarify this comment.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.