[Ns-bugs] [Bug 135] New: Ipv4 'drop' tracing event does not have enough parameters

[bugzilla-daemon@nsnam-www.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=135

           Summary: Ipv4 'drop' tracing event does not have enough
                    parameters
           Product: ns-3
           Version: pre-release
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: internet-node
        AssignedTo: ns-bugs at isi.edu
        ReportedBy: gjcarneiro at gmail.com


Regarding the trace event "/nodes/*/ipv4/drop",

void
Ipv4L3Protocol::SendRealOut (bool found,
                             Ipv4Route const &route,
                             Ptr<Packet> packet,
                             Ipv4Header const &ipHeader)
{
  NS_LOG_FUNCTION;
  NS_LOG_PARAMS (this << found << &route << packet << &ipHeader);

  if (!found)
    {
      NS_LOG_WARN ("No route to host.  Drop.");
      m_dropTrace (packet);
      return;
    }
[...]

In the user callback, only the IPv4 payload is received, but there is not
information regarding the payload type, so I do not know how to decode the
packet (is it UDP, TCP, or...?).

I propose to change the trace callback signature to include also the Ipv4
header:

      m_dropTrace (packet, ipHeader);


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.