[Ns-bugs] [Bug 449] waf regression exit code is zero even if a test fails

[code@nsnam.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=449





--- Comment #4 from Gustavo J. A. M. Carneiro <gjcarneiro at gmail.com>  2008-12-19 13:59:03 EDT ---
(In reply to comment #2)
> 
> That fixed "./waf --regression" (patch was applied) but I still notice a
> problem with "./waf --valgrind  --regression" which is due to valgrind not
> reporting an error code.  The below option would fix it, I believe-- I suggest
> to check it in after the release.
> 
> diff -r 2efae18e7379 wscript
> --- a/wscript   Wed Dec 17 12:54:16 2008 -0800
> +++ b/wscript   Thu Dec 18 05:50:18 2008 -0800
> @@ -461,7 +461,7 @@ def get_command_template(*arguments):
>      if Params.g_options.valgrind:
>          if Params.g_options.command_template:
>              Params.fatal("Options --command-template and --valgrind are
> conflicting")
> -        cmd = "valgrind --leak-check=full %s"
> +        cmd = "valgrind --leak-check=full --error-exitcode=1 %s"
>      else:
>          cmd = Params.g_options.command_template or '%s'
>      for arg in arguments:
> 

The patch looks good.  I actually was not aware that valgrind returned 0 even
when errors were detected.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.