[Ns-bugs] [Bug 162] Calling Object::AggregateObject twice with the same Object type silently succeeds

[bugzilla-daemon@nsnam-www.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=162





------- Comment #3 from tomh at tomh.org  2008-04-09 11:54 -------
(In reply to comment #2)
> (In reply to comment #1)
> > changeset 2895  f8523d79a0b7 
> > fixes the specific problem of re-aggregating Internet stack twice.  (which
> > shouldn't assert-- we should just avoid the re-aggregation)
> 
> I think that this is wrong. It is a programming error to attempt to attach the
> same stack twice to a node. We need to assert. If there are helpers where we do
> this check already, then, these helpers should be changed to not contain the
> check.

The alternative is that we will not be able to pass in a container holding a
multi-interface node to the internet stack helper.  See, for instance, the
mixed-wireless script.

I don't think it is wrong to define the semantics of the AddInternetStack
method to "add an IPv4 stack to the node if one has not already been added". 
Can you elaborate why you think this is a bad idea?  


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.