[Ns-bugs] [Bug 162] Calling Object::AggregateObject twice with the same Object type silently succeeds

[bugzilla-daemon@nsnam-www.ece.gatech.edu]

http://www.nsnam.org/bugzilla/show_bug.cgi?id=162





------- Comment #2 from mathieu.lacage at sophia.inria.fr  2008-04-09 10:45 -------
(In reply to comment #1)
> changeset 2895  f8523d79a0b7 
> fixes the specific problem of re-aggregating Internet stack twice.  (which
> shouldn't assert-- we should just avoid the re-aggregation)

I think that this is wrong. It is a programming error to attempt to attach the
same stack twice to a node. We need to assert. If there are helpers where we do
this check already, then, these helpers should be changed to not contain the
check.

> 
> But the general problem of detecting this isn't yet fixed.

It is trivial to iterate over the list of objects in Object::AggregateObject
prior to adding an object to that list and assert there.


-- 
Configure bugmail: http://www.nsnam.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.